maint(ct): clean up contract tests 1#2334
Merged
mergify[bot] merged 3 commits intodevelopfrom Apr 4, 2022
Merged
Conversation
|
smartcontracts
requested review from
elenadimitrova and
maurelian
as code owners
maurelian
reviewed
Mar 28, 2022
packages/contracts/test/contracts/L1/deployment/ChugSplashDictator.spec..ts
Show resolved
Hide resolved
Contributor
|
Will approve once the filename is fixed. |
smartcontracts
force-pushed
the
sc/ct-clean-tests-1
branch
from
53da16b to
b56967f
Compare
Contributor
Author
Fixed |
mslipper
approved these changes
Mar 31, 2022
smartcontracts
force-pushed
the
sc/ct-clean-tests-1
branch
from
b56967f to
a09cb8b
Compare
smartcontracts
force-pushed
the
sc/ct-clean-tests-1
branch
from
a09cb8b to
3fc4a3a
Compare
First commit in a series of commits to clean up the contract tests. Made a deploy helper function to remove some ugly nested awaits. Also generally starting to remove unnecessary Factory objects.
smartcontracts
force-pushed
the
sc/ct-clean-tests-1
branch
from
3fc4a3a to
b8f2598
Compare
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
adriang-90
pushed a commit
to adriang-90/optimism
that referenced
this pull request
Apr 6, 2022
First commit in a series of commits to clean up the contract tests. Made a deploy helper function to remove some ugly nested awaits. Also generally starting to remove unnecessary Factory objects. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
nebojsa94
pushed a commit
to Tenderly/optimism
that referenced
this pull request
Apr 26, 2022
First commit in a series of commits to clean up the contract tests. Made a deploy helper function to remove some ugly nested awaits. Also generally starting to remove unnecessary Factory objects. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
sam-goldman-zz
pushed a commit
to sam-goldman-zz/optimism
that referenced
this pull request
May 12, 2022
First commit in a series of commits to clean up the contract tests. Made a deploy helper function to remove some ugly nested awaits. Also generally starting to remove unnecessary Factory objects. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First commit in a series of commits to clean up the contract tests. Made
a deploy helper function to remove some ugly nested awaits. Also
generally starting to remove unnecessary Factory objects.